Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option-ext dependency #26

Closed
wants to merge 1 commit into from

Conversation

kpcyrd
Copy link

@kpcyrd kpcyrd commented Dec 31, 2023

I found a way to replace the use of this dependency with a trivial compare.

@soc
Copy link
Collaborator

soc commented Dec 31, 2023

Sorry, but I like it the way it is.

@soc soc closed this Dec 31, 2023
@kpcyrd
Copy link
Author

kpcyrd commented Jan 1, 2024

Why?

@AlexTMjugador
Copy link

AlexTMjugador commented Jan 9, 2024

A dependency for such a trivial operation is rather on the bloatful side, but most importantly, extends the virality of its copyleft MPL license to this MIT/Apache-licensed crate, which does not make much sense:

Cargo deny run on this crate

Can this decision be reconsidered, please? This alone is a reason to stay on dirs v4, which did not have this transitive dependency.

Edit: @kpcyrd, the reason @soc mentioned for this being the way it is can be read here: e169da7#r109131407

@kpcyrd
Copy link
Author

kpcyrd commented Jan 9, 2024

I noticed this PR is an exact duplicate of #24.

@soc
Copy link
Collaborator

soc commented Jan 9, 2024

@AlexTMjugador extends the virality of its copyleft MPL license

?

@AlexTMjugador
Copy link

@AlexTMjugador extends the virality of its copyleft MPL license

?

I wrote that comment before properly researching the situation with this dependency. At the moment, I have no new arguments to add to the discussion about why the dependency on option-ext is, in my opinion, uncomfortable. Other people have already thoroughly explained reasons I can think of in several other issues.

@nihohit
Copy link

nihohit commented Jan 10, 2024

I'd like to join the request - my org forbids the usage of crates using a copyleft license even as an indirect dependency.
@soc I understand that you prefer the code as is, I just hope that you understand that this makes dirs-sys and crates dependent on dirs-sys unusable by some organizations.

@soc
Copy link
Collaborator

soc commented Jan 10, 2024

@nihohit That's fine. Orgs that object even to the tiniest bit of responsibility are "customers" that I can easily do without.

Eugeny pushed a commit to Eugeny/russh that referenced this pull request Aug 2, 2024
It seems like the project ended up with two different dependencies
providing access to the home directory.
This PR consolidates these dependencies into a single dependency.

I've done so by using the `home` crate since on linux it has 0
dependencies and is well supported due to being a part of the cargo
repo.
But if you'd prefer I could swap this PR to use `dirs-next`.

I would like to avoid `dirs` since it is pulling in strange dependencies
dirs-dev/dirs-sys-rs#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants