Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL: Miscellanous Fixes #2266

Merged
merged 2 commits into from
Feb 12, 2024
Merged

QoL: Miscellanous Fixes #2266

merged 2 commits into from
Feb 12, 2024

Conversation

camp00000
Copy link

  1. Fixes a quite annoying when debugging, exception at the end of a successful download when it logs the zipping of the output.
  2. Replaces all logger.warn (deprecated function) calls with logger.warning.

If the 2nd commit is not wanted as it changes quite a few files I can revert it and set the branch back to just fixing the logging call fix mentioned in the first point above.

Also if you have any other suggestions for feasible fixes let me know and/or tag me in the respective issues.

@dipu-bd dipu-bd merged commit 9d2b3d5 into dipu-bd:dev Feb 12, 2024
4 checks passed
@dipu-bd
Copy link
Owner

dipu-bd commented Feb 12, 2024

thanks

@camp00000 camp00000 deleted the misc-fixes branch March 10, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants