Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sniffer: fix mangled newlines on stdout #61

Merged
merged 1 commit into from
Dec 19, 2023
Merged

sniffer: fix mangled newlines on stdout #61

merged 1 commit into from
Dec 19, 2023

Conversation

maxmouchet
Copy link
Member

@maxmouchet maxmouchet commented Dec 19, 2023

Fixes an issue where caracal is sometimes missing a newline, or outputting a newline twice.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c3c47a8) 80.22% compared to head (11d1bec) 80.21%.

❗ Current head 11d1bec differs from pull request most recent head 3935d40. Consider uploading reports for the commit 3935d40 to get more accurate results

Files Patch % Lines
src/sniffer.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   80.22%   80.21%   -0.02%     
==========================================
  Files          23       23              
  Lines        1229     1228       -1     
  Branches      713      712       -1     
==========================================
- Hits          986      985       -1     
  Misses        115      115              
  Partials      128      128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxmouchet maxmouchet changed the title sniffer: fix mangled newlines on stdout output sniffer: fix mangled newlines on stdout Dec 19, 2023
@maxmouchet maxmouchet merged commit 631debf into main Dec 19, 2023
8 checks passed
@maxmouchet maxmouchet deleted the stdout-fix branch December 19, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant