This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Added support for laravel 5.8 #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dimsav
commented
Feb 27, 2019
dimsav
commented
- added support for laravel 5.8
- added tests for php versions 7.1, 7.2, 7.3
Gummibeer
suggested changes
Feb 27, 2019
| - build-php73-laravel57 | ||
| - build-php72-laravel57 | ||
| - build-php71-laravel57 | ||
| - build-php73-laravel56 | ||
| - build-php72-laravel56 | ||
| - build-php71-laravel56 |
There was a problem hiding this comment.
because we don't drop Laravel 5.6 support I would like to keep the lowest possible build here.
| @@ -151,9 +187,9 @@ workflows: | |||
| version: 2 | |||
| build_all: | |||
| jobs: | |||
| - build-php73-laravel58 | |||
| - build-php72-laravel58 | |||
| - build-php71-laravel58 | |||
| - build-php73-laravel57 | |||
There was a problem hiding this comment.
To reduce the amount of builds we can drop build-php73-laravel57 and build-php72-laravel57 as well and build Laravel 5.7 also just with the lowest possible version.
|
could we add the implemented changes from here: #550 |
|
sounds good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.