Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect narrow_phase collisions after using ColliderSet::set_parent #742

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+342 −9
Open

Incorrect narrow_phase collisions after using ColliderSet::set_parent #742

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12c1070
reproduction for case 1 (no collision)
Vrixyz Sep 26, 2024
f30001d
test for wrong self intersection after Collider::set_parent
Vrixyz Sep 27, 2024
aaa91d0
dynamics: remove new parent from contact and intersection graph ; may…
Vrixyz Oct 18, 2024
32f2308
parent testing at the same place a interaction group check, to avoid …
Vrixyz Dec 16, 2024
c0021be
add more asserts in test + more correct comments
Vrixyz Dec 16, 2024
41feb21
add changelog
Vrixyz Dec 16, 2024
b00e486
Update CHANGELOG.md
Vrixyz Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
- Fix `KinematicCharacterController::move_shape` not respecting parameters `max_slope_climb_angle` and `min_slope_slide_angle`.
- Improve ground detection reliability for `KinematicCharacterController`. (#715)
- Fix wasm32 default values for physics hooks filter to be consistent with native: `COMPUTE_IMPULSES`.
- Fix `set_parent` when ongoing collisions should be affected (#742):
Vrixyz marked this conversation as resolved.
Show resolved Hide resolved
- Fix collisions not being removed when a collider is parented to a rigidbody while in collision with it.
- Fix collisions not being added when the parent was removed while intersecting a (previously) sibling collider.

### Added

Expand Down
2 changes: 2 additions & 0 deletions src/geometry/contact_pair.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ impl IntersectionPair {
events: &dyn EventHandler,
) {
self.start_event_emitted = true;
println!("start");
events.handle_collision_event(
bodies,
colliders,
Expand All @@ -99,6 +100,7 @@ impl IntersectionPair {
events: &dyn EventHandler,
) {
self.start_event_emitted = false;
println!("stop");
events.handle_collision_event(
bodies,
colliders,
Expand Down
Loading
Loading