Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track latest bevy main branch #307

Closed
lewiszlw opened this issue Jan 10, 2023 · 1 comment
Closed

Track latest bevy main branch #307

lewiszlw opened this issue Jan 10, 2023 · 1 comment

Comments

@lewiszlw
Copy link

lewiszlw commented Jan 10, 2023

Hi, team
Could you create a branch to track latest bevy main branch? I tried myself https://github.com/lewiszlw/bevy_rapier/tree/bevy_track, but there are blocks for me and I don't have enough knowledge to solve them.
For example, in src/plugin/plugin.rs file, bevy_rapier depends on bevy's internal system transform_propagate_system , but this system has been changed to private in bevyengine/bevy#4775.

   pub fn get_systems(stage: PhysicsStages) -> SystemSet {
        match stage {
            PhysicsStages::SyncBackend => {
                let systems = SystemSet::new()
                    .with_system(systems::update_character_controls) // Run the character controller befor ethe manual transform propagation.
                    .with_system(
                        bevy::transform::transform_propagate_system
                            .after(systems::update_character_controls),
                    ) // Run Bevy transform propagation additionally to sync [`GlobalTransform`]
                    .with_system(
                        systems::init_async_colliders
                            .after(bevy::transform::transform_propagate_system),
                    )
                  ...
                  ...

another example
image

bors bot pushed a commit to bevyengine/bevy that referenced this issue Jan 11, 2023
# Objective

- I tried to create a fork of bevy_rapier to track latest bevy main branch. But bevy_rapier depends on bevy internal `propagate_transforms` system (see https://github.com/dimforge/bevy_rapier/blob/master/src/plugin/plugin.rs#L64).
- `propagate_transforms` system was changed to private in #4775.

I don't know if it's reasonable that making `propagate_transforms` public. I also created an issue to bevy_rapier dimforge/bevy_rapier#307 to see how offical team will solve this issue.

## Solution

- make `propagate_transforms` system public.
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
# Objective

- I tried to create a fork of bevy_rapier to track latest bevy main branch. But bevy_rapier depends on bevy internal `propagate_transforms` system (see https://github.com/dimforge/bevy_rapier/blob/master/src/plugin/plugin.rs#L64).
- `propagate_transforms` system was changed to private in bevyengine#4775.

I don't know if it's reasonable that making `propagate_transforms` public. I also created an issue to bevy_rapier dimforge/bevy_rapier#307 to see how offical team will solve this issue.

## Solution

- make `propagate_transforms` system public.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
# Objective

- I tried to create a fork of bevy_rapier to track latest bevy main branch. But bevy_rapier depends on bevy internal `propagate_transforms` system (see https://github.com/dimforge/bevy_rapier/blob/master/src/plugin/plugin.rs#L64).
- `propagate_transforms` system was changed to private in bevyengine#4775.

I don't know if it's reasonable that making `propagate_transforms` public. I also created an issue to bevy_rapier dimforge/bevy_rapier#307 to see how offical team will solve this issue.

## Solution

- make `propagate_transforms` system public.
@Vrixyz
Copy link
Contributor

Vrixyz commented May 24, 2024

Thanks for helping update bevy_rapier!

I understand the need to update dependencies in a project, PRs are welcome for that, due to the quick changing nature of bevy, as you discovered it's a lot of work to maintain such a branch, with commits added every day, you'll likely end up with your own fork anyway, to match up other dependencies too.

it's usually done near the time of a new release, possibly with a slight delay.

Bevy is currently experimenting a "release candidate" period, which might help with perceived reactivity.

@Vrixyz Vrixyz closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants