Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close: 83 #84

Closed
wants to merge 1 commit into from
Closed

close: 83 #84

wants to merge 1 commit into from

Conversation

nigrosimone
Copy link
Contributor

see #83

@nigrosimone nigrosimone mentioned this pull request Feb 8, 2025
Open
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 8, 2025

Open in Stackblitz

npm i https://pkg.pr.new/dimdenGD/ultimate-express@84

commit: 9ca48aa

@dimdenGD
Copy link
Owner

dimdenGD commented Feb 8, 2025

This is wrong, UltimateExpress doesn't implement Express 5 changes. It only would work with projects that weren't affected by the changes.

https://expressjs.com/en/guide/migrating-5.html

@dimdenGD dimdenGD closed this Feb 8, 2025
@nigrosimone nigrosimone mentioned this pull request Feb 19, 2025
Merged
@nigrosimone
Copy link
Contributor Author

Maybe, because test pass also on v5 (see #85) this PR can be merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigrosimone @dimdenGD