feat: add nest adapter #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
|
Mhh I think it's better publish as separate package. @dimdenGD what do you things? There are so many meta framework based on express... |
|
@ismoiliy98 why not as a new package into https://github.com/nestjs/nest/tree/master/packages ? |
|
Out of scope, it should be a separate package. |
|
This is also discussed on NestJS here nestjs/nest#14075 and has a PR here nestjs/nest#14120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC: Adds support for nest js express adapter.
It just overrides some methods of the original
@nestjs/platform-express.The question is whether it should be published as separate packages or kept within
ultimate-express...