trouble with routes

[tigrazone]

I have this routes

const gallery = require('../controllers/gallery.controller');
const cacheMW = require('../utils/cacheMiddleware');
const translate = require('../utils/translates');
const responseUtils = require('../utils/response_utils');

const setGalleryPageFlag = (req, res, next) => {
  translate(res);
  res.locals.isGalleryPage = true;
  console.log('!!! setGalleryPageFlag');
  next();
};

module.exports = app => {
  router.get('/', setGalleryPageFlag, cacheMW.cache(cacheMW.CACHE_DURATION), gallery.indexFrontPage);

  router.get('/de/', responseUtils.changeLang(2), setGalleryPageFlag, cacheMW.cache(cacheMW.CACHE_DURATION), gallery.indexFrontPage);

  // gallery pages
  router.get('/gallery', setGalleryPageFlag, cacheMW.cache(cacheMW.CACHE_DURATION), gallery.index);

  router.get('/gallery/page/:page', setGalleryPageFlag, cacheMW.cache(cacheMW.CACHE_DURATION), gallery.index);

  router.get('/de/gallery', responseUtils.changeLang(2), setGalleryPageFlag, cacheMW.cache(cacheMW.CACHE_DURATION), gallery.index);

  router.get('/de/gallery/page/:page', responseUtils.changeLang(2), setGalleryPageFlag, cacheMW.cache(cacheMW.CACHE_DURATION), gallery.index);

  app.use('/', router);
};

with express works ok but with ultimate-express cant find
/gallery/page/4 for example and I have 404 on this route

[tigrazone]

doesnt helps

[dimdenGD]

You didn't add router

[nigrosimone]

You didn't add router

Mhh... also works...

const express = require("ultimate-express");

const app = express();

const router = express.Router();

router.get("/", (req, res) => res.status(200).send(""));

router.get("/de/", (req, res) => res.status(200).send(""));

router.get("/gallery", (req, res) => res.status(200).send(""));

router.get("/gallery/page/:page", (req, res) =>
  res.status(200).send(req.params.page)
);

router.get("/de/gallery", (req, res) => res.status(200).send(""));

router.get("/de/gallery/page/:page", (req, res) => res.status(200).send(""));

app.use('/', router);

app.listen(13333, () => {
  console.log("Server is running at http://localhost:13333");
});

[dimdenGD]

I can replicate it when I add a trailing slash at the end of request

[nigrosimone]

I can replicate it when I add a trailing slash at the end of request

Yes! also to me

Cannot GET /gallery/page/4/

[nigrosimone]

It seem uWebSockets behaviour uNetworking/uWebSockets#1049

[tigrazone]

in my case with ultimate-express

/gallery/page/4/ 404
/gallery/page/4 works

how to solve it? just add one more router?
this variant doesnt works

router.get("/gallery/page/:page", (req, res) =>
  res.status(200).send(req.params.page)
);

router.get("/gallery/page/:page/", (req, res) =>
  res.status(200).send(req.params.page)
);

and this variant doesnt works ALSO!!!

router.get("/gallery/page/:page/", (req, res) =>
  res.status(200).send(req.params.page)
);

router.get("/gallery/page/:page", (req, res) =>
  res.status(200).send(req.params.page)
);

µExpress tries to optimize routing as much as possible
;-)

[nigrosimone]

@dimdenGD a possible workaround is redirect all request to non-trailing slash url

#createRequestHandler() {
        this.uwsApp.any('/*', async (res, req) => {
            const { request, response } = this.handleRequest(res, req);

            // redirect to non-trailing slash url
            const host = req.getHeader('host')
            const path = req.getUrl()
            const query = req.getQuery()
            if(path.endsWith('/') && path != '/') return res.writeStatus('301').writeHeader('Location',`//${host}${path.slice(0,-1)}${query?'?'+query:''}`).end()

            const matchedRoute = await this._routeRequest(request, response);
            if(!matchedRoute && !response.headersSent && !response.aborted) {
                response.status(404);
                this._sendErrorPage(request, response, `Cannot ${request.method} ${request.path}`, false);
            }
        });
    }

[tigrazone]

possible workaround is redirect all request to non-trailing slash url

Is must be configureble for some flags.
Because SEO masters have complicated requests sometimes. By default behaviour must be as express works

[nigrosimone]

possible workaround is redirect all request to non-trailing slash url

Is must be configureble for some flags. Because SEO masters have complicated requests sometimes. By default behaviour must be as express works

Sure! Among other things, for SEO purposes, URLs with and without trailing slashes must be treated as two different URLs. If you want to serve the same content, one must perform a 301 redirect to the other.

[tigrazone]

I want just set flag for do it configureble. And I want to see it in documentation

[nigrosimone]

I want just set flag for do it configureble. And I want to see it in documentation

this is my proposal #90

[dimdenGD]

Fixed in 1.3.18