Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recreated] Add support for Python 3.12 #227

Merged
merged 4 commits into from
Sep 6, 2024
Merged

[Recreated] Add support for Python 3.12 #227

merged 4 commits into from
Sep 6, 2024

Conversation

gherceg
Copy link
Contributor

@gherceg gherceg commented Sep 5, 2024

Recreating #219 for the build to pass.

@gherceg
Copy link
Contributor Author

gherceg commented Sep 5, 2024

I'm getting all mixed up, but created #222 to move away from python setup.py test since that is no longer supported in more recent versions of setuptools. This will also remove the need to install setuptools in the test action at all, so I view these two commits as relatively temporary:

AmitPhulera
AmitPhulera approved these changes Sep 6, 2024
View reviewed changes
Copy link

@AmitPhulera AmitPhulera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks for bringing it across the finish line.

@gherceg gherceg merged commit e19a8d1 into master Sep 6, 2024
7 checks passed
@gherceg gherceg deleted the gh/py-312 branch September 6, 2024 14:18
@gherceg gherceg mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitPhulera AmitPhulera AmitPhulera approved these changes

@millerdev millerdev Awaiting requested review from millerdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gherceg @AmitPhulera @nickbaum