Support Python 3.10 #186
Merged
Support Python 3.10 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
PeterJCLaw
force-pushed
the
use-builtin-unittest
branch
from
adf6f35
to
f6c3996
Compare
|
Hrm, not sure why Travis isn't running on this PR? |
|
Yeah I was having the same issue. If you build this PR on top of #190 (or wait for it to get merged), that'll fix any issues with travis (by eliminating travis). If you do that, I suggest you also add python 3.10 to the matrix, since I think that's the point of this PR. Thanks again for the contributions @PeterJCLaw! |
unittest2 appears not to be compatible with Python 3.10, so this is a stepping stone towards getting testing working there.
PeterJCLaw
force-pushed
the
use-builtin-unittest
branch
from
f6c3996
to
6da0947
Compare
PeterJCLaw
changed the title
This seems to already work, so this just enables testing and adds a classifier.
PeterJCLaw
force-pushed
the
use-builtin-unittest
branch
from
009684c
to
eac15ea
Compare
dannyroberts
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
This moves away from
unittest2and then claims support for Python 3.10 (which otherwise appears to already work fine).unittest2appears not to be compatible with Python 3.101, so this is a stepping stone towards getting testing working there.unittest2also appears to be somewhat unmaintained (based on the activity on https://github.com/testing-cabal/unittest-ext), which is somewhat unsurprising given that Python 2 is no longer maintained.In any case, the built-in
unittestmodule seems to have all that's needed here.Footnotes
specifically it relies on various types which have moved out of
collections. ↩