Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BSD license classifier #182

Merged
merged 1 commit into from
May 27, 2021
Merged

Add BSD license classifier #182

merged 1 commit into from
May 27, 2021

Conversation

czue
Copy link
Member

@czue czue commented May 26, 2021

closes #181

@czue czue requested a review from dannyroberts May 26, 2021 06:56
@czue
Copy link
Member Author

czue commented May 26, 2021

@dannyroberts any guidance on this build error? Some additional set of commands I need to run?

=====================================

ERROR: ./.travis/test_cython_files.sh

-------------------------------------

diff --git a/jsonobject/api.c b/jsonobject/api.c

index 9f9114c..c299eac 100644

--- a/jsonobject/api.c

+++ b/jsonobject/api.c

@@ -1,4 +1,4 @@

-/* Generated by Cython 0.29.21 */

+/* Generated by Cython 0.29.23 */

 

 /* BEGIN: Cython Metadata

 {

@@ -12,15 +12,17 @@

 }

 END: Cython Metadata */

 

+#ifndef PY_SSIZE_T_CLEAN

 #define PY_SSIZE_T_CLEAN

+#endif /* PY_SSIZE_T_CLEAN */

 #include "Python.h"

 #ifndef Py_PYTHON_H

     #error Python headers needed to compile C extensions, please install development version of Python.

-------------------------------------

Compiling the C files from scratch shows a difference

The first 20 lines of the diff is shown above

Did you rebuild and commit the changes?  Try running:

    find jsonobject -iname '*.c' -delete

    find jsonobject -iname '*.so' -delete

    python setup.py build_ext --inplace

The command "if [[ $TRAVIS_PYTHON_VERSION > 3.5 ]]; then .travis/test_cython_files.sh; fi" exited with 1.

@dannyroberts
Copy link
Member

I think to fix that you have to run pip install cython== 0.29.23 (see the first few lines of the diff where the version changes) followed by the "Try running" lines

find jsonobject -iname '*.c' -delete
find jsonobject -iname '*.so' -delete
python setup.py build_ext --inplace

which should rebuild the cython files. If you commit the changes that should fix the diff.

@dannyroberts
Copy link
Member

It's admittedly a bummer that that's the responsibility of whoever happens to make a PR after the last time that a new 0.29.x point release of cython is released, but that seems to be how it's set up

Copy link
Member

@dannyroberts dannyroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@czue
Copy link
Member Author

czue commented May 27, 2021

kicked PR build and it's passing now.

@czue czue merged commit 61fed25 into master May 27, 2021
@czue czue deleted the bsd-classifier branch May 27, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license to setup.py
2 participants