Dimadem norminette #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimadem
added a commit
that referenced
this pull request
Sep 10, 2024
* add: get local_vars using $ * add: heredoc now returns expanded env_arvs and loc_args * fix: norminette for heredoc env_var functionality * fix: working on interpreting $a$b together * fix: done echo a$a$b * fix: norminette after a$a$b fix * refactoring * new: errors * add: exit_status * fix:compilation issues * fix: removed error check for | at end of input * fix: removed error check for | at end of input * fix: opened 'ls -la |' readline functionality * fix: opened 'ls -la |' readline functionality * add: CTRL+C sigint in heredocs * fix: CTRL+C in heredocs, working on norminette * fix: CTRL+D functionality passing norminette * fix: heredoc norminette * Dnew backup branch * Dev (#29) * merge: merge_dev into main * merge: merge_dev into main * Merge dev (#28) * add: get local_vars using $ * add: heredoc now returns expanded env_arvs and loc_args * fix: norminette for heredoc env_var functionality * fix: working on interpreting $a$b together * fix: done echo a$a$b * fix: norminette after a$a$b fix * refactoring * new: errors * add: exit_status * fix:compilation issues * fix: builtin_exit * fix * fix:exit * add: norm, fix: issues --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> * Dev (#29) (#30) * merge: merge_dev into main * merge: merge_dev into main * Merge dev (#28) * add: get local_vars using $ * add: heredoc now returns expanded env_arvs and loc_args * fix: norminette for heredoc env_var functionality * fix: working on interpreting $a$b together * fix: done echo a$a$b * fix: norminette after a$a$b fix * refactoring * new: errors * add: exit_status * fix:compilation issues * fix: builtin_exit * fix * fix:exit * add: norm, fix: issues --------- --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> * fix: cat << eof (issue 4) * fix: exit statuses showing again * fix: error codes (issue 1) * fix: history file deleted on exit or sig quit * fix: single and double quotes workgit add .git add .! in heredocs toogit add .git add .git add .! * fix: heredoc quotation marks match bash behaviour * fix: echo rocky 'rocky' rocky USER 0 0 '0' * fix: echo rocky 'rocky' rocky USER 0 0 '0' * fix: CTRL+C add new line after on grep 'we' * Dimadem valgrind (#31) * fix: valgrind * fix: valgrind * fix: ls > output.txt > new.txt --------- Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> * fix: 5. message for CTRL+\ on exit. * merged branches * fix: 3 memory leaks with no input, only exit after start * reset to working version (exit error) * fix: 2 leaks, (signal and path in execute.c * fix:valgrind exit * fix: add_env leak, add_shell_var leak * SAFE TO REVERT TO - improved structuring of files only * mid-debugging, still works well. Revert to here if necessary * about to refactor new_ast_node & tree, safe to RESET to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * pipe giving double free but I think this is the right way forward * pipe giving double free but I think this is the right way forward * got through tokenizer, pipe still doesn't work but made changes i wan tot keep * I think I'm close but there are errors. Fixing ast vs tokens list free conflict * AST & TOKENS FREE CONFLICT RESOLVED BITCHEZZZZZZZZZZ * debugging pipe malloc (and mayeb functionality) issue * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * fix: many things. I have become one with minishell. Tomorrow we fix env & loc vars. * Roman 7sept (#32) * SAFE TO REVERT TO - improved structuring of files only * mid-debugging, still works well. Revert to here if necessary * about to refactor new_ast_node & tree, safe to RESET to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * pipe giving double free but I think this is the right way forward * pipe giving double free but I think this is the right way forward * got through tokenizer, pipe still doesn't work but made changes i wan tot keep * I think I'm close but there are errors. Fixing ast vs tokens list free conflict * AST & TOKENS FREE CONFLICT RESOLVED BITCHEZZZZZZZZZZ * debugging pipe malloc (and mayeb functionality) issue * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * fix: many things. I have become one with minishell. Tomorrow we fix env & loc vars. --------- Co-authored-by: Roman Mikhaylenko <roman.mikhaylenko14@hotmail.com> * fix: env valgrind * fix: valgrind shell_var * fix * merged with dimas work from today (9th) from dev * added malloc debugger statements * no leak checks with echo simple arg * fixed memory leaks for echo multiple simple args * env vars are working (without echo) * Dimadem norminette (#33) * fix:norm backend * fix: norminette * fix: norm * delete: printf --------- Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> * fix:issues * rmikhayl 'rmikhayl' rmikhayl USER 0 0 '0' worksgit add . loc args, let's see * almost there, just some env/loc/exit vars to iron out in heredoc * holy shit I think all the memory leaks are fixed * everything works except for loc vars in heredocs * EVERY MEMORY LEAK FIXED OH MAA GAAAWD * YAAAAAAAAAAAAAAAAAAS THIS IS ALL HEALTHY * only norminette for the 2 loc_env files left to dogit add .git add .git add .git add .git add . * working on norminette, so far no leaks * split functions across files, preparing for refactoring. Reset to here if needed * loc_env_var_heredoc_utils norminette passing! safe to revert to here * new checkpoint, loc_env_car_handler is fine * new checkpoint, loc_env_car_handler is fine * new checkpoint, loc_env_car_handler & utils_utils are fine * one function left to go * one function left to go * think all checks are still passed, manually split up expand_variable * is it done? * its done * tidied up non-ft functions --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> Co-authored-by: Roman Mikhaylenko <roman.mikhaylenko14@hotmail.com>
dimadem
added a commit
that referenced
this pull request
Sep 10, 2024
* add: get local_vars using $ * add: heredoc now returns expanded env_arvs and loc_args * fix: norminette for heredoc env_var functionality * fix: working on interpreting $a$b together * fix: done echo a$a$b * fix: norminette after a$a$b fix * refactoring * new: errors * add: exit_status * fix:compilation issues * fix: removed error check for | at end of input * fix: removed error check for | at end of input * fix: opened 'ls -la |' readline functionality * fix: opened 'ls -la |' readline functionality * add: CTRL+C sigint in heredocs * fix: CTRL+C in heredocs, working on norminette * fix: CTRL+D functionality passing norminette * fix: heredoc norminette * Dnew backup branch * Dev (#29) * merge: merge_dev into main * merge: merge_dev into main * Merge dev (#28) * add: get local_vars using $ * add: heredoc now returns expanded env_arvs and loc_args * fix: norminette for heredoc env_var functionality * fix: working on interpreting $a$b together * fix: done echo a$a$b * fix: norminette after a$a$b fix * refactoring * new: errors * add: exit_status * fix:compilation issues * fix: builtin_exit * fix * fix:exit * add: norm, fix: issues --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> * Dev (#29) (#30) * merge: merge_dev into main * merge: merge_dev into main * Merge dev (#28) * add: get local_vars using $ * add: heredoc now returns expanded env_arvs and loc_args * fix: norminette for heredoc env_var functionality * fix: working on interpreting $a$b together * fix: done echo a$a$b * fix: norminette after a$a$b fix * refactoring * new: errors * add: exit_status * fix:compilation issues * fix: builtin_exit * fix * fix:exit * add: norm, fix: issues --------- --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> * fix: cat << eof (issue 4) * fix: exit statuses showing again * fix: error codes (issue 1) * fix: history file deleted on exit or sig quit * fix: single and double quotes workgit add .git add .! in heredocs toogit add .git add .git add .! * fix: heredoc quotation marks match bash behaviour * fix: echo rocky 'rocky' rocky USER 0 0 '0' * fix: echo rocky 'rocky' rocky USER 0 0 '0' * fix: CTRL+C add new line after on grep 'we' * Dimadem valgrind (#31) * fix: valgrind * fix: valgrind * fix: ls > output.txt > new.txt --------- Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> * fix: 5. message for CTRL+\ on exit. * merged branches * fix: 3 memory leaks with no input, only exit after start * reset to working version (exit error) * fix: 2 leaks, (signal and path in execute.c * fix:valgrind exit * fix: add_env leak, add_shell_var leak * SAFE TO REVERT TO - improved structuring of files only * mid-debugging, still works well. Revert to here if necessary * about to refactor new_ast_node & tree, safe to RESET to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * pipe giving double free but I think this is the right way forward * pipe giving double free but I think this is the right way forward * got through tokenizer, pipe still doesn't work but made changes i wan tot keep * I think I'm close but there are errors. Fixing ast vs tokens list free conflict * AST & TOKENS FREE CONFLICT RESOLVED BITCHEZZZZZZZZZZ * debugging pipe malloc (and mayeb functionality) issue * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * fix: many things. I have become one with minishell. Tomorrow we fix env & loc vars. * Roman 7sept (#32) * SAFE TO REVERT TO - improved structuring of files only * mid-debugging, still works well. Revert to here if necessary * about to refactor new_ast_node & tree, safe to RESET to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * restructured AST, safe to roll back to here * pipe giving double free but I think this is the right way forward * pipe giving double free but I think this is the right way forward * got through tokenizer, pipe still doesn't work but made changes i wan tot keep * I think I'm close but there are errors. Fixing ast vs tokens list free conflict * AST & TOKENS FREE CONFLICT RESOLVED BITCHEZZZZZZZZZZ * debugging pipe malloc (and mayeb functionality) issue * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * FIXED PIPE & TOKEN AST DISCONTINUITYYYYYYYY * fix: many things. I have become one with minishell. Tomorrow we fix env & loc vars. --------- Co-authored-by: Roman Mikhaylenko <roman.mikhaylenko14@hotmail.com> * fix: env valgrind * fix: valgrind shell_var * fix * merged with dimas work from today (9th) from dev * added malloc debugger statements * no leak checks with echo simple arg * fixed memory leaks for echo multiple simple args * env vars are working (without echo) * Dimadem norminette (#33) * fix:norm backend * fix: norminette * fix: norm * delete: printf --------- Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> * fix:issues * rmikhayl 'rmikhayl' rmikhayl USER 0 0 '0' worksgit add . loc args, let's see * almost there, just some env/loc/exit vars to iron out in heredoc * holy shit I think all the memory leaks are fixed * everything works except for loc vars in heredocs * EVERY MEMORY LEAK FIXED OH MAA GAAAWD * YAAAAAAAAAAAAAAAAAAS THIS IS ALL HEALTHY * only norminette for the 2 loc_env files left to dogit add .git add .git add .git add .git add . * working on norminette, so far no leaks * split functions across files, preparing for refactoring. Reset to here if needed * loc_env_var_heredoc_utils norminette passing! safe to revert to here * new checkpoint, loc_env_car_handler is fine * new checkpoint, loc_env_car_handler is fine * new checkpoint, loc_env_car_handler & utils_utils are fine * one function left to go * one function left to go * think all checks are still passed, manually split up expand_variable * is it done? * its done * tidied up non-ft functions * Hell yeah branch (#35) * submission * FINISHED * fix: bugs --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> --------- Co-authored-by: ¨Roman <¨roman.mikhaylenko14@hotmail.com¨> Co-authored-by: Dmitry Demirkylych <dmdemirk@c2r5s7.42london.com> Co-authored-by: Dmitry Demirkylych <dmdemirk@c1r3s4.42london.com> Co-authored-by: Roman Mikhaylenko <roman.mikhaylenko14@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.