Fix deprecation warning in re.sub
for Python 3.13
#287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know xlsx2csv doesn't officially support Python 3.13, but there is no reason it couldn't!
We support
xlsx2csv
as an engine in Polars and we'd like to support Python 3.13. Currently, usingxlsx2csv
works fine but it throws a deprecation warning:re.sub
now expects thecount
parameter as a keyword argument rather than positional.I checked earlier versions of Python (3.4 onwards and 2.7) and it seems that in all cases, the parameter is named
count
, so using a keyword argument here shouldn't break anything.It was a simple fix, hopefully this can be a tiny step towards Python 3.13 support!