Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STDIN input broken #270

Closed
3 tasks done
ferdinandyb opened this issue Dec 12, 2023 · 1 comment · Fixed by #271
Closed
3 tasks done

STDIN input broken #270

ferdinandyb opened this issue Dec 12, 2023 · 1 comment · Fixed by #271
Assignees
@ferdinandyb

Comments

@ferdinandyb
Copy link
Contributor

ferdinandyb commented Dec 12, 2023 •
edited
Loading

Commit 5a14efc broke 8a4c028, which added the usual - to indicate stdin. Reported by @Konfekt in #264.

Todo:

  • fix broken commit
  • add - to documentation
  • add - to tests
@ferdinandyb
Copy link
Contributor Author

@dilshod feel free to assign this to me if you agree with the above

ferdinandyb added a commit to ferdinandyb/xlsx2csv that referenced this issue Dec 13, 2023
@ferdinandyb
stdin: fix false no file test and add tests for stdin
3fe49b1 
Commit 5a14efc broke input from stdin, with the check added for
actually existing files. Add an exception when the file input is "-" so
reading from stdin works again. The original commit that introduced this
feature did not include documentation. Add documentation to "--help",
manpages and the README. Add testing for reading from stdin with python3
so future commits will not break the feature unintentionally.

Fixes: dilshod#270
@ferdinandyb ferdinandyb mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferdinandyb ferdinandyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stdin: fix false no file test and add tests for stdin ferdinandyb/xlsx2csv
1 participant
@ferdinandyb