Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added env example and unfollow users who aren't following you example #1452

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Added env example and unfollow users who aren't following you example #1452

merged 4 commits into from
Jun 15, 2021

Conversation

sell
Copy link
Contributor

@sell sell commented Jun 11, 2021

Added:

  • env example
  • added an example where you can unfollow users who aren't following you

Nerixyz
Nerixyz requested changes Jun 11, 2021
View reviewed changes
Copy link
Collaborator

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only the generics should be added for typescript to infer the types.

.env.example Outdated Show resolved Hide resolved
examples/unfollow-users.example.ts Outdated Show resolved Hide resolved
examples/unfollow-users.example.ts Outdated Show resolved Hide resolved
sell and others added 3 commits June 11, 2021 19:43
@sell @Nerixyz
Update .env.example
4b7b52d 
Co-authored-by: nerix <nero.9@hotmail.de>
@sell @Nerixyz
Update examples/unfollow-users.example.ts
10b3580 
Co-authored-by: nerix <nero.9@hotmail.de>
@sell @Nerixyz
Update examples/unfollow-users.example.ts
e4e4681 
Co-authored-by: nerix <nero.9@hotmail.de>
sell
sell commented Jun 11, 2021
View reviewed changes
Copy link
Contributor Author

@sell sell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged changes you suggested

@sell
Copy link
Contributor Author

sell commented Jun 15, 2021

What's the average time for a pr to be merged? No rush, just curious.

@Nerixyz
Copy link
Collaborator

Nerixyz commented Jun 15, 2021

As it's only an example, I can merge it.

@Nerixyz Nerixyz merged commit d914b59 into dilame:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerixyz Nerixyz Nerixyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sell @Nerixyz