Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 704 #709

Open
wants to merge 3 commits into
base: stable-1.9
Choose a base branch
from

Conversation

james-d-mitchell
Copy link
Member

This PR fixes issue #704. It seems that the previously installed method for SubdigraphsMonomorphisms was just wrong (right in all the examples we checked but not all). This PR re-implements the method, this time hopefully correct. The performance is unfortunately worse than the previous incorrect method, I might be able to do something about that but it might be more or less complicated, so I thought I'd post this.

@MeikeWeiss can you please take a look and confirm that this resolves your issue?

MeikeWeiss and others added 3 commits September 11, 2024 20:39
Bumps [mamba-org/setup-micromamba](https://github.com/mamba-org/setup-micromamba) from 1 to 2.
- [Release notes](https://github.com/mamba-org/setup-micromamba/releases)
- [Commits](mamba-org/setup-micromamba@v1...v2)

---
updated-dependencies:
- dependency-name: mamba-org/setup-micromamba
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@james-d-mitchell james-d-mitchell added the bugfix A label for PRs that fix a bug label Oct 10, 2024
@MeikeWeiss
Copy link
Contributor

Thank you very much! This solves my problem and I have also tested several examples. Sorry it took so long, but while testing I found a bug in my code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A label for PRs that fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants