Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startup bug #688

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix startup bug #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73abc50
Fix startup for GAP versions before 4.12.0
james-d-mitchell Aug 30, 2024
f0d7fd2
Ignore autodoc generated files
james-d-mitchell Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
.ipynb_checkpoints
*.DS_Store
*.Plo
*.Tpo
*.a
*.aux
*.bbl
*.blg
*.brf
*.digraphs
*.DS_Store
*.dylib
*.g6
*.gcda
Expand All @@ -23,7 +24,6 @@
*.o
*.out
*.pdf
*.Plo
*.pnr
*.pyc
*.six
Expand All @@ -35,11 +35,12 @@
*.tex
*.toc
*.top
*.Tpo
*.tui
*.txt
.ipynb_checkpoints
/doc/*.css
/doc/*.js
Makefile
aclocal.m4
autom4te.*
bin/
Expand All @@ -50,9 +51,9 @@ coverage
depcomp
digraphs-config.h
digraphs-lib
doc/_*.xml
gen/
gh-pages/
Makefile
manual.lab
missing
src/pkgconfig.h.in
Expand Down
10 changes: 10 additions & 0 deletions PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ _STANDREWSMATHS := Concatenation(["Mathematical Institute, North Haugh, ",
_STANDREWSCS := Concatenation(["Jack Cole Building, North Haugh, ",
"St Andrews, Fife, KY16 9SX, Scotland"]);

if not CompareVersionNumbers(GAPInfo.Version, "4.12") then
IsKernelExtensionAvailable := fail;
fi;

SetPackageInfo(rec(
PackageName := "Digraphs",
Subtitle := "Graphs, digraphs, and multidigraphs in GAP",
Expand Down Expand Up @@ -444,6 +448,8 @@ AvailabilityTest := function()
"the package cannot be loaded."]);
return fail;
fi;
# Stop GAP from erroring that IsKernelExtensionAvailable is not a bound
# global in the next line.
fi;
return true;
end,
Expand All @@ -452,3 +458,7 @@ Autoload := false,
TestFile := "tst/teststandard.g",
Keywords := []
));

if not CompareVersionNumbers(GAPInfo.Version, "4.12") then
Unbind(IsKernelExtensionAvailable);
fi;
Loading