kernel: use GAP's GVAR_FUNC macro #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @fingolfin! Any chance you could please run clang-format on |
james-d-mitchell
added
the
C language
... to get rid of some repetition
fingolfin
force-pushed
the
mh/GVAR_FUNC
branch
from
4fa49fa
to
761342d
Compare
|
Done |
|
Note that this now has a conflict with the changes on master. But I have a script to regenerate this -- so if you prefer I can also change this to target latest master with the new hash function in it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to get rid of some repetition
This macro has been available since GAP 4.9.
Since GAp 4.12 we also have
GVAR_FUNC_0ARGS,GVAR_FUNC_1ARGS,GVAR_FUNC_2ARGS, etc. which also help catch bugs (e.g. mismatch between number of arguments of the given C function and what GAP is being promised here). But since this package still tries to be compatible with GAP 4.10 I didn't make use of them.