Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test that relies on xpdf not being installed #578

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

mtorpey
Copy link
Collaborator

@mtorpey mtorpey commented Apr 11, 2023

Previously, the tests in display.tst try to call Splash with "xpdf" as the viewer, and we expect an error to be thrown. This only works if xpdf is not installed, and if xpdf is installed then the tests fail.

This commit changes the test to a dummy viewer which will definitely not be installed.

Previously, the tests in display.tst try to call Splash with "xpdf" as the viewer, and we expect an error to be thrown.  This only works if xpdf is not installed, and if xpdf is installed then the tests fail.

This commit changes the test to a dummy viewer which will definitely not be installed.
@mtorpey mtorpey added the tests A label for issues/PRs relating to adding or updating tests or the testing system label Apr 11, 2023
@mtorpey mtorpey requested a review from wilfwilson April 11, 2023 16:00
@mtorpey
Copy link
Collaborator Author

mtorpey commented Apr 11, 2023

From my computer on the main branch:

gap> DigraphsTestStandard();                                          
Architecture: x86_64-pc-linux-gnu-default64-kv8

testing: /home/mtorpey/.gap/pkg/Digraphs/tst/standard/attr.tst
    2705 ms (127 ms GC) and 685MB allocated for attr.tst
testing: /home/mtorpey/.gap/pkg/Digraphs/tst/standard/cliques.tst
     728 ms (284 ms GC) and 37.6MB allocated for cliques.tst
testing: /home/mtorpey/.gap/pkg/Digraphs/tst/standard/constructors.tst
     189 ms (153 ms GC) and 3.52MB allocated for constructors.tst
testing: /home/mtorpey/.gap/pkg/Digraphs/tst/standard/digraph.tst
    1115 ms (128 ms GC) and 359MB allocated for digraph.tst
testing: /home/mtorpey/.gap/pkg/Digraphs/tst/standard/display.tst
########> Diff in /home/mtorpey/.gap/pkg/Digraphs/tst/standard/display.tst:440
# Input is:
Splash("string", rec(viewer := "xpdf"));
# Expected output:
Error, the viewer "xpdf" specified in the option `viewer` is not available,
# But found:
Error, the component "type" of the 2nd argument <a record>  must be "dot" or "\
latex",
########
false

@james-d-mitchell
Copy link
Member

Also resolves #577 !

@james-d-mitchell james-d-mitchell merged commit 843eaff into digraphs:main Apr 12, 2023
@mtorpey mtorpey deleted the allow-xpdf-installation branch April 12, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests A label for issues/PRs relating to adding or updating tests or the testing system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants