Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos found by codespell #569

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

fingolfin
Copy link
Contributor

No description provided.

@james-d-mitchell
Copy link
Member

Seems like some of the typos are in error messages which is why the test are failing, o/w this is fantastic, didn't know about codespell, but am very happy to have these changes. I'm not 100% sure it makes sense to correct spelling in the comments of the vendored bliss and planarity, any chance that those could be removed from the PR?

@fingolfin
Copy link
Contributor Author

fingolfin commented Dec 9, 2022

I agree that nothing under extern should be modified, and will remove this -- I didn't pay enough attention, sorry.

One issue is that sometimes homogeneous and sometimes homogenous is used -- I thought both are correct and synonyms, but in truth, it seems that while both are valid words, they mean different things, at least according to https://writingexplained.org/homogenous-vs-homogeneous

I'll fix these to be consistent

@james-d-mitchell james-d-mitchell added the enhancement A label for PRs that provide enhancements. label Dec 9, 2022
@james-d-mitchell james-d-mitchell merged commit 0f35ebc into digraphs:stable-1.6 Dec 9, 2022
@fingolfin fingolfin deleted the mh/codespell branch March 27, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A label for PRs that provide enhancements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants