-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite buildsystem to use Makefile.gappkg #566
Conversation
The test failure seems spurious (failed to clone the repo?). I'll wait for PR #567 to be merged, then will rebase, and we'll see how the tests fare then -- also those done against conda |
6bbc87c
to
c93b6eb
Compare
Good that the azure tests run again, they immediately discovered a problem ( |
Thanks! I'll test on OpenBSD and report. |
This should remove the problems on OpenBSD, and speed up build times.
c93b6eb
to
991de69
Compare
Just to say that @fingolfin and I discussed this today, and I'll be happy to merge this when you tell me you're done @fingolfin. Many thanks! |
should this be tested on GAP master, or on another branch? |
@dimpase whichever is handy for you (and of course the OpenBSD problem should manifest, I don't know whether you tested this with multiple GAP versions) |
@james-d-mitchell from my POV this is done but perhaps we wait and see what @dimpase reports? |
This allows one to build working Digraphs (DigraphsTestAll() passed). Now, the same dylib build problem with Semigroups. Opening an issue there. |
@dimpase out of curiosity, what does |
Excellent thanks very much @fingolfin ! I'll wait to hear the last word from @dimpase, then merge |
it says
whereas for
without this PR ldd was failing on |
it's a big OK from me. |
This should remove the problems on OpenBSD (see issue #562, CC @dimpase), and speed up build times.
I have done some limited testing on macOS and Linux. Before I spend more time on polish, I'll wait to hear if there is any interest in this (plus CI results will of course be interesting).