-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random filters #531
Random filters #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of changes requested here, but all minor.
One general comment for something that comes up everywhere: don't call Digraph(...)
. Instead use DigraphNC(...)
. It's the same thing but without the user-level input checks, which aren't required if we're generating adjacency lists algorithmically.
… Acyclic, Symmetric)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realised that I can push changes to this branch, so I did the required linting myself and have rebased. This now looks like it'll pass, and I'm happy with it!
I'll merge it once the final checks are done.
This is for his work on random digraphs that was recently merged (PR #531).
This is for his work on random digraphs that was recently merged (PR #531).
No description provided.