Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random filters #531

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Random filters #531

merged 7 commits into from
Jun 23, 2022

Conversation

KamranKSharma
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mtorpey mtorpey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of changes requested here, but all minor.

One general comment for something that comes up everywhere: don't call Digraph(...). Instead use DigraphNC(...). It's the same thing but without the user-level input checks, which aren't required if we're generating adjacency lists algorithmically.

doc/digraph.xml Outdated Show resolved Hide resolved
doc/digraph.xml Outdated Show resolved Hide resolved
doc/digraph.xml Show resolved Hide resolved
gap/digraph.gi Show resolved Hide resolved
gap/digraph.gi Show resolved Hide resolved
gap/digraph.gi Outdated Show resolved Hide resolved
gap/digraph.gi Outdated Show resolved Hide resolved
gap/digraph.gi Outdated Show resolved Hide resolved
gap/digraph.gi Outdated Show resolved Hide resolved
gap/digraph.gi Outdated Show resolved Hide resolved
doc/digraph.xml Outdated Show resolved Hide resolved
gap/digraph.gi Outdated Show resolved Hide resolved
@KamranKSharma KamranKSharma requested a review from mtorpey May 4, 2022 21:37
@james-d-mitchell james-d-mitchell added the new-feature A label for new features. label Jun 15, 2022
Copy link
Collaborator

@mtorpey mtorpey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised that I can push changes to this branch, so I did the required linting myself and have rebased. This now looks like it'll pass, and I'm happy with it!

I'll merge it once the final checks are done.

@mtorpey mtorpey merged commit 6cde1b3 into digraphs:master Jun 23, 2022
mtorpey added a commit that referenced this pull request Jun 25, 2022
This is for his work on random digraphs that was recently merged (PR #531).
james-d-mitchell pushed a commit that referenced this pull request Aug 5, 2022
This is for his work on random digraphs that was recently merged (PR #531).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A label for new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants