Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: fix check in OutNeighbours #519

Merged

Conversation

james-d-mitchell
Copy link
Member

This PR fixes Issue #518.

Copy link
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@james-d-mitchell
Copy link
Member Author

The CI fails because of some issues with the wording of errors, any idea how I can add this test and get around this @wilfwilson ?

Error, expected a digraph, not a homogeneous plain list
Error, expected a digraph, not a list (plain,hom)

@wilfwilson
Copy link
Collaborator

I've pushed a slightly different test, I hope you don't mind. If you do OutNeighbours(OutNeighbours) then you get a consistent error message across GAP versions:

Error, expected a digraph, not a function

Once we require GAP 4.11, these kinds of problems will be straightforward to work around because you can use the syntax #@if, #@else, and #@endif in test files to test stuff conditionally, and to expect different outputs.

@james-d-mitchell
Copy link
Member Author

I've pushed a slightly different test, I hope you don't mind.

Thanks!

Once we require GAP 4.11, these kinds of problems will be straightforward to work around because you can use the syntax #@if, #@else, and #@endif in test files to test stuff conditionally, and to expect different outputs.

I didn't know this! Awesome!

@james-d-mitchell james-d-mitchell merged commit c5c78df into digraphs:stable-1.5 Nov 25, 2021
@james-d-mitchell james-d-mitchell deleted the fix-issue-518 branch November 25, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants