-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OnTuplesDigraphs
and OnSetsDigraphs
#449
Add OnTuplesDigraphs
and OnSetsDigraphs
#449
Conversation
f1fc793
to
3ce296f
Compare
@wilfwilson looks good, I'll be happy to discuss your first two points this afternoon if you want? |
For the second point, I think it's not necessary; these new operations use |
For the first point, I'm not sure. The current (and simplest to implement) behaviour, as demonstrated with digraph
This just seems really weird to me, that you ask to apply the perm Of course, for immutable digraphs, you get the list |
3ce296f
to
c870756
Compare
c870756
to
35d0f59
Compare
9797c6e
to
2a9fd31
Compare
2a9fd31
to
14130a9
Compare
14130a9
to
e1ec750
Compare
e1ec750
to
12aff56
Compare
12aff56
to
f483d93
Compare
55258de
to
7072e5f
Compare
This now has documentation and tests, and it is now ready for review. Hopefully it is clear from the documentation and implementation how I dealt with mutable digraphs: I copy them before acting on them by I just didn't see a sensible use-case for For It's also the list/set itself that we're acting on by In addition, I think |
54f92f7
to
0e6a836
Compare
0e6a836
to
f2ff8b2
Compare
I keep writing temporary functions to implement these actions for my research, so I thought it was about time I just add them to the package.
Tasks:
IsDigraphByOutNeighboursRepCollection
OnTuplesDigraphs
OnSetsDigraphs