ViewString: special case for trees and forests #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
added
enhancement
wilfwilson
force-pushed
the
tree-is-bipartite
branch
6 times, most recently
from
142d8fe
to
33828b3
Compare
wilfwilson
force-pushed
the
tree-is-bipartite
branch
from
33828b3
to
3dc1b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that undirected trees and forests didn't know that they were bipartite, so I've added this implication via an
InstallTrueMethod.UndirectedSpanningTrees also didn't know that they were undirected trees, so I've added this too.It then became a bit weird that these digraphs would be shown as
<immutable bipartite symmetric connected digraph...>or something like that.The
ViewStrings now say "...forest digraph..." and "...tree digraph..." - should I drop the 'digraph'? I thought it best to keep it in, so that it's clear to a user that these are digraph objects, but I'm not strongly of that opinion.