Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StarDigraph #424

Merged
merged 11 commits into from
Mar 11, 2021
Merged

Add StarDigraph #424

merged 11 commits into from
Mar 11, 2021

Conversation

LRacine
Copy link
Contributor

@LRacine LRacine commented Mar 1, 2021

This creates a star graph as defined by https://en.wikipedia.org/wiki/Star_(graph_theory).

@LRacine LRacine added the new-feature A label for new features. label Mar 1, 2021
gap/examples.gi Outdated Show resolved Hide resolved
@marinaanagno
Copy link
Contributor

Also the star graph S_n is isomorphic to the complete bipartite graph K_{1, n - 1}, which already exists in the package as CompleteBipartiteDigraph, if I'm not mistaken :)

doc/examples.xml Outdated Show resolved Hide resolved
doc/examples.xml Outdated Show resolved Hide resolved
@wilfwilson wilfwilson mentioned this pull request Mar 10, 2021
gap/examples.gi Outdated Show resolved Hide resolved
Copy link
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code is fine, I had one or two comments on the documentation (some just echoing what Alex said).

doc/examples.xml Outdated Show resolved Hide resolved
doc/examples.xml Outdated Show resolved Hide resolved
@digraphs digraphs deleted a comment from codecov bot Mar 11, 2021
wilfwilson
wilfwilson previously approved these changes Mar 11, 2021
Copy link
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes @LRacine! I've going to make a few more suggestion (mostly technical things) which I'll commit through the GitHub interface, and then I'll merge if it all seems okay!

gap/examples.gi Outdated Show resolved Hide resolved
gap/examples.gi Outdated Show resolved Hide resolved
gap/examples.gi Outdated Show resolved Hide resolved
gap/examples.gi Outdated Show resolved Hide resolved
tst/standard/examples.tst Outdated Show resolved Hide resolved
tst/standard/examples.tst Outdated Show resolved Hide resolved
doc/examples.xml Outdated Show resolved Hide resolved
doc/examples.xml Outdated Show resolved Hide resolved
doc/examples.xml Outdated Show resolved Hide resolved
gap/examples.gi Outdated Show resolved Hide resolved
@wilfwilson wilfwilson merged commit 8ec17bf into digraphs:master Mar 11, 2021
@@ -87,6 +87,7 @@
<#Include Label="JohnsonDigraph">
<#Include Label="PetersenGraph">
<#Include Label="GeneralisedPetersenGraph">
<#Include Label="StarDigraph">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LRacine I added this line so that your documentation would actually be linked into the manual - without it, the manual entry doesn't end up in the manual, and can't be accessed within GAP by typing ?StarDigraph. You'll need to do the same thing for your tadpole graph in PR #423.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, thank you!!

@wilfwilson wilfwilson changed the title Star graph Add StarDigraph Mar 11, 2021
@LRacine LRacine deleted the star-graph branch March 18, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A label for new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants