Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue #320 (Doc config options) #420

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

james-d-mitchell
Copy link
Member

@james-d-mitchell james-d-mitchell commented Mar 1, 2021

See Issue #320.

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #420 (829de5e) into stable-1.4 (1c4a0f0) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           stable-1.4     #420   +/-   ##
===========================================
  Coverage       97.21%   97.21%           
===========================================
  Files              45       45           
  Lines           12315    12315           
===========================================
  Hits            11972    11972           
  Misses            343      343           

@james-d-mitchell james-d-mitchell added the doc Issues, bugs, pull requests relating to the documentation label Mar 1, 2021
README.md Outdated Show resolved Hide resolved
doc/z-chap1.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful

README.md Outdated Show resolved Hide resolved
doc/z-chap1.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added code suggestions to Alex's comments so that I can commit them now and get this PR merged.

README.md Outdated Show resolved Hide resolved
doc/z-chap1.xml Outdated Show resolved Hide resolved
@wilfwilson wilfwilson merged commit a825d4e into digraphs:stable-1.4 Mar 3, 2021
james-d-mitchell added a commit to james-d-mitchell/Digraphs that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues, bugs, pull requests relating to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants