Add GridGraph

[finnbuck]

Added two new operations, for constructing square and triangular grid graphs. Also added tests for these functions.

[samanthaharper]

Looks good, you just need documentation and to fix a few little things.

[wilfwilson]

I've made some suggestion, which I'll commit via the GitHub interface. I'm then going to make a few more changes locally and then push them to your branch.

[wilfwilson]

I've made some further changes and I think it's good to go. Have a look @finnbuck and if there's anything you want to complain about that I did, or any further changes you'd like to make, go ahead!

[finnbuck]

No complaints, thanks! The triangular grid graph really is just the square grid graph with extra edges so it makes complete sense for it to just call the square grid graph first...

[finnbuck]

Also, is there anything in particular that needs to go in the merge message when the branch is merged? By default it just says 'Add GridGraph'.

[wilfwilson]

No not really, I've just cleaned up the history and force-pushed to resolve the merge conflicts again (the branch couldn't be merged as it was) - sorry if I'm stepping on your toes.

I just called the one commit "Add SquareGridGraph and TriangularGridGraph (PR #416)" – you're still down in the git history as the author, don't worry 🙂

I'll merge if the tests pass, once again.

[finnbuck]

Ok, that sounds great. Thanks again for walking me through all the steps!

[wilfwilson]

You're welcome!