Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FolkmanGraph #386

Closed
wants to merge 1 commit into from
Closed

Add FolkmanGraph #386

wants to merge 1 commit into from

Conversation

finnbuck
Copy link
Contributor

Added functions for constructing a Folkman Graph. @james-d-mitchell

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #386 (038ddd5) into master (0c909dd) will decrease coverage by 1.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   97.01%   95.34%   -1.67%     
==========================================
  Files          45       50       +5     
  Lines       12884    13121     +237     
==========================================
+ Hits        12499    12510      +11     
- Misses        385      611     +226     
Impacted Files Coverage Δ
gap/examples.gd 100.00% <100.00%> (ø)
gap/examples.gi 98.95% <100.00%> (+0.03%) ⬆️
src/bitarray.c 93.33% <0.00%> (-1.91%) ⬇️
gap/attr.gi 99.31% <0.00%> (-0.69%) ⬇️
src/planar.c 93.75% <0.00%> (-0.37%) ⬇️
src/perms.c 77.77% <0.00%> (-0.35%) ⬇️
src/homos-graphs.c 98.66% <0.00%> (-0.27%) ⬇️
src/homos.c 99.08% <0.00%> (-0.07%) ⬇️
src/cliques.c 99.26% <0.00%> (-0.04%) ⬇️
gap/labels.gi 98.64% <0.00%> (-0.03%) ⬇️
... and 18 more

@finnbuck
Copy link
Contributor Author

We have decided to go a different direction with named graphs. However, this version of the Folkman Graph implementation could still be useful as a template.

@james-d-mitchell james-d-mitchell added the do not merge A label for PRs that should not be merged for whatever reason. label Feb 28, 2021
@james-d-mitchell
Copy link
Member

Thanks @finnbuck we did decide to go in a different direction for sporadic (i.e. non-infinite families of) digraphs, but I think we should leave this open for the purpose that you mentioned @finnbuck, as an exemplar of what to do to add an infinite family. Thanks for this!

@james-d-mitchell james-d-mitchell mentioned this pull request Feb 28, 2021
Copy link
Contributor

@olexandr-konovalov olexandr-konovalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@wilfwilson wilfwilson changed the title Folkman Add FolkmanGraph Mar 26, 2021
@wilfwilson wilfwilson force-pushed the folkman branch 2 times, most recently from e5bf02f to 014c915 Compare May 22, 2021 13:08
Co-authored-by: Finn Buck <finneganlbuck@gmail.com>
Co-authored-by: James D. Mitchell <jdm3@st-andrews.ac.uk>
@wilfwilson
Copy link
Collaborator

If this is not intended to be merged, I think it's probably an appropriate point to close this PR now, right? (Seeing as there are already several examples of this kind that have now been merged).

@james-d-mitchell
Copy link
Member

Closing this as it was an exemplar only!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge A label for PRs that should not be merged for whatever reason.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants