-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FolkmanGraph
#386
Add FolkmanGraph
#386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 97.01% 95.34% -1.67%
==========================================
Files 45 50 +5
Lines 12884 13121 +237
==========================================
+ Hits 12499 12510 +11
- Misses 385 611 +226
|
We have decided to go a different direction with named graphs. However, this version of the Folkman Graph implementation could still be useful as a template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks!
e5bf02f
to
014c915
Compare
Co-authored-by: Finn Buck <finneganlbuck@gmail.com> Co-authored-by: James D. Mitchell <jdm3@st-andrews.ac.uk>
If this is not intended to be merged, I think it's probably an appropriate point to close this PR now, right? (Seeing as there are already several examples of this kind that have now been merged). |
Closing this as it was an exemplar only! |
Added functions for constructing a Folkman Graph. @james-d-mitchell