Add checks for upper/lower semimodular lattices #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
added
new-feature
This comment has been minimized.
This comment has been minimized.
james-d-mitchell
force-pushed
the
semimodular
branch
from
e1a3e57 to
e010dc5
Compare
james-d-mitchell
force-pushed
the
semimodular
branch
from
e010dc5 to
cf6339b
Compare
james-d-mitchell
force-pushed
the
semimodular
branch
from
cf6339b to
6648498
Compare
|
This should be good to go. If @reiniscirpons or @wilfwilson could give it a look over, I'd be most grateful. |
james-d-mitchell
force-pushed
the
semimodular
branch
3 times, most recently
from
1622cb8 to
c8cc43a
Compare
james-d-mitchell
force-pushed
the
semimodular
branch
from
c8cc43a to
2c818f7
Compare
wilfwilson
approved these changes
Jan 6, 2022
Co-authored-by: Wilf Wilson <wilf@wilf-wilson.net>
|
Thanks @wilfwilson, I agree with all of your comments! |
|
Something weird happened with the GitHub Actions macOS job (it failed to compile the profiling package), I propose that we ignore it and not waste the time re-running the tests. It can't be related to this PR, and macOS jobs are running fine on other PRs. |
finnbuck
pushed a commit
to finnbuck/Digraphs
that referenced
this pull request
Mar 16, 2022
* attr: support upper/lower semimodular lattices * Apply suggestions from code review Co-authored-by: Wilf Wilson <wilf@wilf-wilson.net> Co-authored-by: Wilf Wilson <wilf@wilf-wilson.net>
james-d-mitchell
added a commit
to james-d-mitchell/Digraphs
that referenced
this pull request
Apr 6, 2022
* attr: support upper/lower semimodular lattices * Apply suggestions from code review Co-authored-by: Wilf Wilson <wilf@wilf-wilson.net> Co-authored-by: Wilf Wilson <wilf@wilf-wilson.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.