Add ModularProduct #354
Merged
Add ModularProduct #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
added
WIP
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 95.30% 95.31%
=======================================
Files 50 50
Lines 12953 12989 +36
=======================================
+ Hits 12345 12380 +35
- Misses 608 609 +1
|
|
I think this is good to go. |
wilfwilson
reviewed
Dec 22, 2020
wilfwilson
reviewed
Dec 22, 2020
wilfwilson
approved these changes
Dec 22, 2020
|
Thanks @wilfwilson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially introduces the
ModularProductof two digraphs, as used in @le27's PR #334. When trying to understand the code in PR #334, I wrote the method in this PR. It seems to be about 10 times faster than the method in PR #334 for finding the modular product, but it doesn't do exactly the same thing.@le27 can I suggest that you finish this PR off (add tests and documentation), and then use the
ModularProductin your other PR #334?It's possible that it would be beneficial to have a
ReducedModularProductoperation too (which basically returns the same thing asReducedDigraph(ModularProduct(D));but without the creation of the intermediate (possibly too large)ModularProduct(D)). Having said that I don't think the time consuming part ofReducedDigraph(ModularProduct(D));is the call toReducedDigraphso this might also not be worth it.