Fix issue 222 #223
Merged
Fix issue 222 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolved Issue #222 |
wilfwilson
reviewed
Jul 15, 2019
tst/standard/grahom.tst
Outdated
| <digraph with 6 vertices, 18 edges> | ||
| gap> mono := MonomorphismsDigraphs(D1, D2); | ||
| [ ] | ||
| gap> ForAll(mono, f -> IsDigraphHomomorphism(D1, D2, f)); |
There was a problem hiding this comment.
I recommend you get rid of these two ForAll calls, they're a bit redundant.
james-d-mitchell
force-pushed
the
fix-issue-222
branch
from
8dca75b to
a51c4b6
Compare
wilfwilson
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue 222. Previously the monomorphism finding code did not properly ensure that the found homomorphisms were injective. This PR fixes this by removing all points in the image of a partial monomorphism from the set of vertices that can be chosen for the image of the next point.