Add GeneralisedPetersenGraph function #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
requested changes
Jun 14, 2019
doc/exmpl.xml
Outdated
|
|
||
| For more information, see <URL>https://en.wikipedia.org/wiki/Generalized_Petersen_graph</URL><P/> | ||
|
|
||
| See also <Ref Func="DigraphsTestInstall"/>. |
There was a problem hiding this comment.
Why do we see also DigraphsTestInstall??
doc/exmpl.xml
Outdated
| <#GAPDoc Label="GeneralisedPetersenGraph"> | ||
| <ManSection> | ||
| <Attr Name="GeneralisedPetersenGraph" Arg="n, k"/> | ||
| <Returns>A digaph.</Returns> |
| <immutable digraph with 10 vertices, 30 edges> | ||
| gap> IsIsomorphicDigraph(D, PetersenGraph()); | ||
| true | ||
| ]]></Example> |
There was a problem hiding this comment.
Why not add an example which returns a mutable digraph? Other manual examples don't do this only because they haven't yet been updated.
gap/exmpl.gi
Outdated
| if n + i + k <= 2 * n then | ||
| DigraphAddEdge(D, [n + i, n + i + k]); | ||
| else | ||
| DigraphAddEdge(D, [n + i, (n + i + k) mod n + n]); |
There was a problem hiding this comment.
Maybe some brackets around ((n + i + k) mod n) + n?
wilfwilson
reviewed
Jun 14, 2019
tst/standard/exmpl.tst
Outdated
| <immutable digraph with 10 vertices, 30 edges> | ||
| gap> IsIsomorphicDigraph(D, PetersenGraph()); | ||
| true | ||
| gap> mat8_3 := [[0, 0, 0, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0], |
There was a problem hiding this comment.
You could make this all much shorter by just doing:
gap> G8_3 := DigraphFromGraph6String("OCQa`Q?OH?a@A@@?_OGB@");
wilfwilson
approved these changes
Jun 19, 2019
james-d-mitchell
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the Generalised Petersen Graphs to the standard examples, using the construction as described here.