Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize ac_find_gap.m4 #150

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Modernize ac_find_gap.m4 #150

merged 1 commit into from
Nov 22, 2018

Conversation

fingolfin
Copy link
Contributor

  • drop CONFIGNAME support
  • make it possible to compile against future GAP releases with
    compatibility mode turned off

* drop CONFIGNAME support
* make it possible to compile against future GAP releases with
  compatibility mode turned off
@fingolfin
Copy link
Contributor Author

BTW I based this on stable-0.13, so if you'd rather merge this there, it's trivial to retarget this PR.

@wilfwilson wilfwilson merged commit d53feb2 into digraphs:master Nov 22, 2018
@fingolfin fingolfin deleted the mh/m4 branch November 22, 2018 17:05
@wilfwilson
Copy link
Collaborator

@james-d-mitchell I merged this without talking to you, hope that's alright, but I noticed this in the README which is now out of date somehow:

If you installed GAP on several architectures, you must execute the configure/make step for each of the architectures. You can either do this immediately after configuring and compiling GAP itself on this architecture, or alternatively (when using version 4.5 of GAP or newer) set the environment variable CONFIGNAME to the name of the configuration you used when compiling GAP before running ./configure. Note however that your compiler choice and flags (environment variables CC and CFLAGS) need to be chosen to match the setup of the original GAP compilation. For example you have to specify 32-bit or 64-bit mode correctly!

@james-d-mitchell
Copy link
Member

No problem, I'm happy for you to merge things without talking to me!

What's the correct advice for the README now?

@wilfwilson
Copy link
Collaborator

I don't know what needs to be done to make it correct, that's why mostly I've brought it to your attention. But certainly the stuff about CONFIGNAME should be removed. I've no idea about any of this compilation stuff really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants