Fix issue #111 #117
Merged
Fix issue #111 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
force-pushed
the
fix-issue-111
branch
from
d3dfd49
to
f5f0dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #111, which was caused by orbit representatives in the homomorphism finding code being chosen to the the least element in any orbit, and only considering the image values of the homomorphism from among those orbit representatives. If the image was restricted to values which were not orbit representatives (i.e. that were not the least point in their orbits), as in Issue #111, then this could result in no homomorphism being found, when a homomorphism exists.