Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var.session_role_name should be optional #4

Closed
nocode99 opened this issue Jul 26, 2022 · 1 comment
Closed

var.session_role_name should be optional #4

nocode99 opened this issue Jul 26, 2022 · 1 comment

Comments

@nocode99
Copy link

This var is passed into the shell script and is only used when you're assuming a role (which is also optional). I'm happy to make a PR but just curious what the reasoning is for it.
@rquadling
Copy link
Member

Oh. I've no idea why I didn't make it optional. Happy to receive a PR. And apologies for not getting back to you sooner.

rquadling added a commit that referenced this issue Nov 28, 2022
@rquadling
Prepare v5.0.4
719807e 
- Allow `var.role_session_name` to be optional. Thank you [Byron Kim](#4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rquadling @nocode99