Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from uglifier to terser #62

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

george-gca
Copy link

@george-gca george-gca commented Jul 13, 2024

Changed from uglifier to terser for better ES6 support.

I created this PR as a draft since I don't know how to test these changes properly. I'd love some advice to better testing them so they would be considered to merge.

Signed-off-by: George Araujo <george.gcac@gmail.com>
@digitalsparky
Copy link
Owner

Hi George,

Thanks so much I'll undoubtedly take a look at this and get it merged as soon as possible.
Please note that I do have a pain disability, so am unable to consistently work, so it may take a little bit.

Thanks so much for your support

Matt

@george-gca
Copy link
Author

george-gca commented Jul 19, 2024

I didn't create tests for this or even tested in my machine because I have no idea how to set up a dev environment for gems. If you can help me or direct me to a good tutorial I am more than happy to guarantee that this actually works as expected. I just made the changes that seemed necessary for this to work properly.

Also if I manage to test this I could add the set up dev environment in another PR for your repo, no problem.

@ricky-ratnayake-trend
Copy link

Any progress on this? =) It looks like the current version of jekyll-minifier with uglifier is broken on Window WSL (platform ruby:x86_64-linux for me) and terser might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants