Exclusion fix #28
Merged
Exclusion fix #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coercing all the keys to symbols affects attempting to access the exclusion property; the first time it will work as a string, but after the coercion, it must be accessed as a symbol as such, it is just simpler to use string keys throughout
and memoize the value
This was referenced Jul 8, 2017
Closed
|
Thanks for your contribution :). |
|
My pleasure! Thank you for this convenient plugin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a typo in the branch name on the other pull request, so here is an improved one!
This fixes persistent issues with excluding files. In essence, the coercion from string keys to symbol keys in
output_htmlviolated idempotency; i.e. the first attempt to get theexcludesetting would work via a string, but then failed in subsequent attempts, since a symbol would be required. This pull request just uses string keys throughout.I also greatly simplified how exclusion checking works by making use of
Kernel#Array,Array#any?, andHash#dig.