Iterate the pre-check to include an interoperability check #239
Conversation
mpanne
commented
Dec 16, 2024
mpanne
commented
- Add questions regarding EU interoperability
- Update pre-check landing and result pages to include information about interoperability
- Add page with general information prior to pre-check questions
- Update content of some pre-check pages
mpanne
force-pushed
the
feature_interoperability-pre-check
branch
6 times, most recently
from
1ce6d24 to
9c30b6d
Compare
There was a problem hiding this comment.
Hey, great work! I left a mix of nitpicks and medium proposals, lmk if you need any clarification.
With the possible refactorings and maybe pulling some components out of ResultPage (ReasoningList first and foremost probably), I am starting to think we might get away without the three files and could still merge route.tsx and ResultPage. Interested in your thoughts!
| @@ -26,7 +26,6 @@ jobs: | |||
|
|
|||
| build-and-push-image: | |||
| needs: [check-and-test-shared] | |||
| if: ${{ github.ref == 'refs/heads/main' }} | |||
There was a problem hiding this comment.
Doesn't this lead to PR branches (e.g. by dependabot) being deployed, too?
There was a problem hiding this comment.
Yes, that's the whole point of it. To have the PR branches built so that we can use the published images for staging deployment (manually atm). That way we could also test a dependabot PR on staging. Whereas I agree that this is more an unwanted side effect than a feature. Do you see a problem with this approach?
| } | ||
| > | ||
| <Container backgroundColor="white" additionalClassNames="rounded-b-lg"> | ||
| <div className="pb-40 border-solid border-0 border-b-2 border-gray-400 last:border-0 last:pb-0"> |
There was a problem hiding this comment.
border-0 seems unnecessary here
mpanne
force-pushed
the
feature_interoperability-pre-check
branch
from
8a286be to
181d79f
Compare
For smaller screens additionally to progress bar.
For some reason the constant location resulted in failing e2e tests due to not resolvable dependencies in vorpruefung._index.tsx
Additionally to the result for digital rediness aspects.
-removes info "VO tritt ab Januar in Kraft" - changed word from "EU-Länder" to "EU-Mitgliedsstaaten
changed instruction text
Resolve the content for the result page from the answers of the pre-check in an uoi agnostic way so that it can be used for the email content as well.
Include result, reasoning, negative reasoning and all answers
mpanne
force-pushed
the
feature_interoperability-pre-check
branch
from
5a27cbc to
bd7665d
Compare
With the new ResultPage in one file, the component does not add any value
