Fix flaky test

digitalservicebund · Jan 3, 2025 · e55bad1 · e55bad1
1 parent 562256c
commit e55bad1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/dito/tests/e2e/examplePages.spec.ts b/packages/dito/tests/e2e/examplePages.spec.ts
@@ -78,7 +78,7 @@ test.describe("Digitaltauglichkeit Prinzipien Detail", () => {
         lawLinks.first().click(),
       ]);
 
-      await newTab.waitForLoadState("load");
+      await newTab.waitForLoadState("networkidle");
       await expect(newTab).toHaveURL(new RegExp(`${ROUTE_LAWS.url}/.+`));
 
       const mainContent = newTab.getByRole("main");

diff --git a/packages/dito/tests/e2e/methodPages.spec.ts b/packages/dito/tests/e2e/methodPages.spec.ts
@@ -145,13 +145,22 @@ test.describe("five principles page", () => {
 
     for (const [index, url] of links.entries()) {
       await page.goto(ROUTE_METHODS_FIVE_PRINCIPLES.url);
-      await Promise.all([page.waitForLoadState("networkidle")]);
+
+      await Promise.all([
+        page.waitForLoadState("domcontentloaded"),
+        page.waitForLoadState("networkidle"),
+      ]);
 
       const link = page
         .getByRole("link", { name: "Beispiele betrachten" })
         .nth(index);
 
-      await Promise.all([page.waitForURL(url), link.click()]);
+      await expect(link).toBeVisible();
+      const navigationPromise = page.waitForURL(url);
+      await link.click();
+      await navigationPromise;
+
+      await expect(page).toHaveURL(url);
     }
   });
 });