Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Firewall Resource exported attributes documentation to match actual. #648

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fixes Firewall Resource exported attributes documentation to match actual. #648

merged 1 commit into from
Jun 21, 2021

Conversation

ziazon
Copy link
Contributor

@ziazon ziazon commented Jun 17, 2021

Corrects documentation of inbound and outbound rules exported attributes.

@ziazon
Update firewall.md
d5bf70d 
Corrects documentation of inbound and outbound rules exported attributes.
andrewsomething
andrewsomething approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch! Thanks!

@andrewsomething andrewsomething merged commit 282609d into digitalocean:main Jun 21, 2021
@MattIPv4
Copy link

Hey, @jubairsaidi - Thanks a ton for this PR! 😄

Would you please shoot me an email when you get a chance?
mcowley at digitalocean dot com 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziazon @MattIPv4 @andrewsomething