Fix docs and validation for expiry_seconds on registry docker credentials resource. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
added a commit
that referenced
this pull request
Apr 26, 2021
…ials resource. (#582) * Correct container registry docker credentials docs. * Move validation of expiry_seconds to schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
updateExpiredDockerCredentialsfunction gets called when the state is being refreshed, but the change to the configuration is not available at refresh. So you can encounter a situation like #581 where a bad value has been set in state but the validation prevents the value from being corrected. We should prevent the bad value from ever being entered in the first place.Fixes: #581