fix: add opensearch_acl to data.digitalocean_database_user schema #1290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced when
opensearch_acl
support was added to the database cluster resource (#1215). The resource and data source share theflattenUserSettings
method. When the data source attempts to set the emptyopensearch_acl
to state, it errors as it is not part of the datasource schema.terraform-provider-digitalocean/digitalocean/database/resource_database_user.go
Lines 348 to 357 in f27a112
The acceptance test did not catch this as the user needs to have a
setting
block in the API response as the method checks itsettings
isnil
. A brand new Postgres user does not, but adoadmin
user does, e.g.Updated test now passes, but before the change would fail with:
Fixes: #1289