Bump Go version to v1.21.0 #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danaelhe
approved these changes
Aug 28, 2023
bboreham
reviewed
Oct 11, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/digitalocean/godo | |||
|
|
|||
| go 1.18 | |||
| go 1.21 | |||
There was a problem hiding this comment.
FYI this creates a problem for downstream users of this library who want their software to be compatible with multiple versions of Go.
Example: prometheus/prometheus#12964
Since nothing in this package requires Go 1.21, it's unnecesary to have it as a minimum requirement.
There was a problem hiding this comment.
Thanks for flagging this @bboreham! This was a mistake. We've cut a bug fix release (v1.104.1) dropping this to Go 1.20 and documenting our policy of following the upstream Go policy of supporting the two latest major releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.