Add TLS and SSH Dialers, and support libvirt URI parsing #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneb
added a commit
to zaneb/openshift-installer
that referenced
this pull request
Feb 20, 2024
This is a static (pure golang) library that is used by the libvirt terraform module. Import it in the top-level go module. For now we use a replace directive while we wait for connection URI support (including TLS and SSH dialers) to land upstream in digitalocean/go-libvirt#209.
trapgate
approved these changes
Feb 20, 2024
|
Hang in there. The CI setup for go-libvirt has gotten a little long-in-the-tooth and needed updating. I've got a separate PR open to fix that; once it has merged you can update this PR and the tests should succeed. |
|
The CI updates are merged; if you pull the latest changes into your fork the tests should pass. |
When opening a connection with the libvirt client, the provided URI is first used to set up the socket used to communicate with libvirtd. The actual URI passed to libvirtd (i.e. when calling the ConnectToURI() method) contains only a subset of the original, since relative to libvirtd the underlying virt provider is always local. Create a new ConnectToURI() function that returns a connected Libvirt using the appropriate dialer and remote URI.
This is a simpler way to initiate a connection.
All of the hard parts are now implemented by the dialer, so the example can be much more straightforward.
This is needed for ssh support.
Resolve qemu+ssh:// URIs using the internal (golang ssh library--based) ssh dialer. Note that this cannot respect the system ssh configuration, as users of the libvirt client library would (since it shells out to the ssh binary for these URIs, unlike for qemu+libssh:// or qemu+libssh2:// URIs).
|
Thanks! Rebased the branch on that CI change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Dialer for TLS connections. This removes the need for consumers of the library to write a lot of TLS setup code, and abstracts the weird part of the connection protocol discussed in #89.
Add a Dialer for SSH connections, using the golang stdlib ssh library.
Introduce a function to connect to an arbitrary libvirt connection URI. This removes the need for every consumer to reimplement this functionality if they want user-configurable connection parameters, and greatly simplifies the process of opening a connection. The transports that are implemented are
unix,tcp,tls,libssh2,libssh, andssh.Note that for now all 3 of the ssh transports are implemented using the same golang ssh library for connection, so the behaviour may not always be identical to the libvirt client (in particular the
sshtransport would normally be expected to pick up settings from the user's.ssh/configfile by virtue of it shelling out to the ssh client).Fixes #139
Fixes #143
Fixes #189