Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes dependencies to 1.14.1 and adjust code #209

Merged
merged 5 commits into from
Apr 16, 2019

Conversation

timoreimann
Copy link
Contributor

@timoreimann timoreimann commented Apr 15, 2019

Besides being more up-to-date in general and supporting Kubernetes 1.14, the update will also allow us to customize LB names in the future (and thus address #102).

Changes in detail:

  • Update package imports.
  • Implement new interface function around load balancer naming (without modifying the naming schema).
  • Use cobra command-based bootstrapping method to ensure all flags are set properly. (This will require enabling the allow-untagged-cloud flag on the CLI.)
  • Update end-to-end tests.
  • Follow upstream in switching from glog to klog.

Note: Due to the way cloud providers are to be initialized now (basically by calling a factory function that returns a Cobra command), we cannot in-code-enable the flag allowing untagged clouds easily anymore. As such, the flag should move to the CLI in form of the --allow-untagged-cloud parameter.

@timoreimann timoreimann changed the title Upgrade k8s deps to 1.14 Update Kubernetes dependencies to 1.14.1 and adjust code Apr 15, 2019
@timoreimann
Copy link
Contributor Author

This supersedes #165.

@timoreimann
Copy link
Contributor Author

I needed to pin the dependency for apimachinery (replace in Go modules lingo) to 1.14.1 for some reason. Haven't digged into why it's needed, but it certainly is.

- Update package imports.
- Implement new interface function around load balancer naming (without
  modifying the naming schema).
- Use cobra command-based bootstrapping method to ensure all flags are
  set properly. (This will require enabling the allow-untagged-cloud
  flag on the CLI.)
- Update end-to-end tests.
- Follow upstream in switching from glog to klog.
@timoreimann
Copy link
Contributor Author

Submitted an upstream fix for the workaround we had to do around the GCE-only flag problem (see main.go in this PR).

Copy link

@jcodybaker jcodybaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about the docs, but otherwise good by me if it's well tested across our known versions.

verflag.PrintAndExitIfRequested()

// digitalocean overrides
s.KubeCloudShared.AllowUntaggedCloud = true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timoreimann and I had an offline discussion about this. Because of the upstream changes were no longer able to do this, but it sounds like we need to change the parameters required to invoke the CCM. We should also update the documentation in this PR so they ride together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- I pushed a commit that updates the docs. PTAL again.

@timoreimann
Copy link
Contributor Author

Also confirming that the new version was tested on Kubernetes 1.11 through 1.13. The latest release 1.14 will be tested as soon as images are readily available for us.

@timoreimann timoreimann merged commit 4d82a0c into master Apr 16, 2019
@timoreimann timoreimann deleted the upgrade-k8s-deps-to-1.14 branch April 16, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants