-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kubernetes dependencies to 1.14.1 and adjust code #209
Conversation
269406b
to
638947d
Compare
This supersedes #165. |
I needed to pin the dependency for apimachinery ( |
638947d
to
105325a
Compare
- Update package imports. - Implement new interface function around load balancer naming (without modifying the naming schema). - Use cobra command-based bootstrapping method to ensure all flags are set properly. (This will require enabling the allow-untagged-cloud flag on the CLI.) - Update end-to-end tests. - Follow upstream in switching from glog to klog.
105325a
to
c88a079
Compare
Submitted an upstream fix for the workaround we had to do around the GCE-only flag problem (see main.go in this PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note about the docs, but otherwise good by me if it's well tested across our known versions.
verflag.PrintAndExitIfRequested() | ||
|
||
// digitalocean overrides | ||
s.KubeCloudShared.AllowUntaggedCloud = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timoreimann and I had an offline discussion about this. Because of the upstream changes were no longer able to do this, but it sounds like we need to change the parameters required to invoke the CCM. We should also update the documentation in this PR so they ride together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch -- I pushed a commit that updates the docs. PTAL again.
Also confirming that the new version was tested on Kubernetes 1.11 through 1.13. The latest release 1.14 will be tested as soon as images are readily available for us. |
Besides being more up-to-date in general and supporting Kubernetes 1.14, the update will also allow us to customize LB names in the future (and thus address #102).
Changes in detail:
Note: Due to the way cloud providers are to be initialized now (basically by calling a factory function that returns a Cobra command), we cannot in-code-enable the flag allowing untagged clouds easily anymore. As such, the flag should move to the CLI in form of the
--allow-untagged-cloud
parameter.