Support v1beta1 snapshots #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
support-v1beta1-snapshots
branch
9 times, most recently
from
07ee849
to
ede7d28
Compare
timoreimann
force-pushed
the
support-v1beta1-snapshots
branch
5 times, most recently
from
c2dbe5f
to
7845c3f
Compare
timoreimann
force-pushed
the
support-v1beta1-snapshots
branch
2 times, most recently
from
4ea5966
to
f3e7c9b
Compare
MorrisLaw
approved these changes
Jun 16, 2020
README.md
Outdated
| --- | ||
| **Note:** | ||
|
|
||
| The [DigitalOcean Kubernetes](https://www.digitalocean.com/products/kubernetes/) products comes with the CSI driver pre-installed and no further steps are required. |
| kind: VolumeSnapshot | ||
| metadata: | ||
| name: csi-do-test-snapshot | ||
| spec: | ||
| source: | ||
| name: csi-do-test-pvc | ||
| kind: PersistentVolumeClaim | ||
| persistentVolumeClaimName: csi-do-test-pvc |
| metadata: | ||
| name: do-block-storage | ||
| namespace: kube-system |
There was a problem hiding this comment.
Why is this no longer in the kube-system namespace?
There was a problem hiding this comment.
VolumeSnapshotClass never really was in a namespace because the object is non-namespaced. I removed it to make things more clear.
timoreimann
force-pushed
the
support-v1beta1-snapshots
branch
from
54a8cbb
to
4c6f8e6
Compare
This change adds support for v1beta1 snapshots. The change is breaking, meaning that v1alpha1 snapshots cannot be used anymore. Consequently, we also stop testing for Kubernetes releases below 1.17 which do did not support v1beta1 snapshots. Changes in detail: - Update manifests, including the addition of the new snapshot controller and update of the csi-snapshotter and csi-provisioner sidecars. - Split up release manifests into multiple files to limit kustomize usage to manifests that require modification for testing. In particular, the snapshot controller is excluded which does not support running in a dev and non-dev version concurrently. - Update examples. - Update CI and build references to Kubernetes releases. - Remove VolumeSnapshotDataSource feature gate which is enabled by default since 1.17. - Remove integration tests that were needed for Kubernetes <1.14 only. - Extend documentation.
timoreimann
force-pushed
the
support-v1beta1-snapshots
branch
from
4c6f8e6
to
f37cdb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for v1beta1 snapshots. The change is breaking, meaning that v1alpha1 snapshots cannot be used anymore. Consequently, we also stop testing for Kubernetes releases below 1.17 which do did not support v1beta1 snapshots.
Changes in detail:
kustomizeusage to manifests that require modification for testing. In particular, the snapshot controller is excluded which does not support running in a dev and non-dev version concurrently.VolumeSnapshotDataSourcefeature gate which is enabled by default since 1.17.