Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes dependencies to 1.17 #307

Merged
merged 4 commits into from
Apr 29, 2020

Conversation

timoreimann
Copy link
Collaborator

Details:

  • Add script and Makefile target to easily update Kubernetes dependencies.
  • Update Kubernetes dependencies to 1.17.5.
  • Adjust code to dependency refactorings.

Copy link
Contributor

@waynr waynr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈


deps=()

while read -ra LINE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took your suggestion from slack the other day: https://github.com/digitalocean/digitalocean-cloud-controller-manager/blob/master/scripts/update-k8s.sh

So instead of the dependencies that are already listed in the go.mod file the script linked above curls the upstream kubernetes go.mod at the appropriate version. It also moves the k8s.io/kubernetes dependency outside the loop since of course the upstream go.mod doesn't list itself as a dependency the same way it lists its components as dependencies and we do still need a replace directive for it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did pull down the CCM version of that script but then failed by committing an old, local copy I still had. :)

Should be fixed now.

@timoreimann timoreimann force-pushed the upgrade-kubernetes-dependencies-to-1.17 branch from e70284d to 52ad765 Compare April 29, 2020 17:02
@timoreimann timoreimann merged commit 231876f into master Apr 29, 2020
@timoreimann timoreimann deleted the upgrade-kubernetes-dependencies-to-1.17 branch April 29, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants