Fix ListSnapshots paging #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
fix-listsnapshots-paging
branch
2 times, most recently
from
2608e1a
to
e2bd611
Compare
nicktate
approved these changes
Apr 21, 2020
This changes provides the following fixes and improvements to ListSnapshots: - Use paging to collect snapshots beyond the first page. Previously, we would only return snapshots from the first page. - Handle StartingToken and MaxEntries such that we use paging efficiently and skip initial, unneeded snapshots. - Extend fake snapshot driver to support paging. - Add tests. Note that Kubernetes / the csi-snapshotter sidecar currently do not invoke ListSnapshots without the snapshot ID parameter, which means that the fixed code is not executed in production. However, it is used by csi-test / the sanity package, and other COs (Container Orchestrators) may potentially use it as well as Kubernetes going forward.
timoreimann
force-pushed
the
fix-listsnapshots-paging
branch
from
e2bd611
to
883126e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes provides the following fixes and improvements to
ListSnapshots:StartingTokenandMaxEntriessuch that we use paging efficiently and skip initial, unneeded snapshots.Note that Kubernetes / the csi-snapshotter sidecar currently do not invoke
ListSnapshotswithout the snapshot ID parameter, which means that the fixed code is not executed in production. However, it is used by csi-test / the sanity package, and other COs (Container Orchestrators) may potentially use it as well as Kubernetes going forward.